-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate new backend changes through poseidon377
#53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redshiftzero
force-pushed
the
non-arkworks-feat
branch
from
February 22, 2024 03:10
7d4243c
to
022e041
Compare
This was referenced Feb 28, 2024
redshiftzero
force-pushed
the
non-arkworks-feat
branch
from
April 1, 2024 20:47
24d4227
to
f45ba1a
Compare
redshiftzero
force-pushed
the
non-arkworks-feat
branch
from
April 3, 2024 16:43
092a819
to
5a52402
Compare
redshiftzero
force-pushed
the
non-arkworks-feat
branch
from
April 4, 2024 19:27
f523159
to
6b25ac1
Compare
redshiftzero
changed the title
wip: propagate new backend changes through
Propagate new backend changes through Apr 4, 2024
poseidon377
poseidon377
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #3675
One of the changes that will need to happen here to propagate the backend changes through
poseidon377
is makingdecaf377
a dependency ofposeidon-parameters
andposeidon-permutation
instead ofark-ff
(previously these two crates were generic overark_ff::PrimeField
)TODO
poseidon-parameters
- this compiles now on the target platform, all tests passposeidon-paramgen
(i.e. make it use the latestposeidon-parameters
) - may do this in a followup, it's not included currently as a build time dependency in favor of using the hardcoded existing parameter set, filed followup restoreposeidon-paramgen
#58poseidon-permutation
- this compiles now on the target platform, all tests passposeidon377
- this compiles now on the target platform, all tests passFq
) into decaf377: preparing here add power impl and exposeFq::from_montgomery_limbs
decaf377#98Followups
generic_const_exprs
is stabilized, these crates can be simplified significantly, e.g. the structs with parametersSTATE_SIZE
andSTATE_SIZE_MINUS_1
can beSTATE_SIZE, STATE_SIZE - 1
. Similarly,NUM_ELEMENTS
can be removed in favor of computingNUM_ROWS * NUM_COLS
- filed as cleanup crates when rustgeneric_const_exprs
is stabilized #57poseidon-paramgen
- restoreposeidon-paramgen
#58Test Plan
We're testing each package builds in the target environment via: